I've been a smoker for way too many years now (please, no comments I already get enough from my daughters) and over the years I've bought or been given lots of different kinds of lighters.
I carry a Zippo every day. In my packpack, BOB and campkitchen bag I carry spare "Bic" type lighters and waterproof matches. If I could find some I'd also have the old fashioned strike anywhere matches.
As for re-fillable butane lighters I've been given a couple of really good ones and for some reason I've never had any luck with them. Seems like they always wind up leaking and I am constantly re-filling them.
For someone that isn't a smoker and wants to just have a lighter in their pocket for emergencies I'd go with the Bic types. Cheap, lighweight and unless they are completely soaked thy work. Downside is that in high wind they are difficult to keep lit.