Clean tap water or bottled water should keep indefinitely if you keep it away from light. Bottled water might taste a bit plasticky after a few years, and the bottles themselves might start to break down after a few more years.