I rotate out the stored water every 2-3 months. Our tap water is usually not chlorinated. I would still consider the water fine after 6 months or so, but other members of the household are dubious about drinking it when it has been stored that long, so I change it more often than that and note the date on stick on labels at the time. Half the supply is stored in a large cooler (one of those tough ones with wheels that you can sit on). This keeps it out of the light and I reckon that even if the house fell on it the darn thing would survice.
I've got a mixture of recycled soda bottles and white plastic food grade bottles. Nothing above 5 liters as I have too much trouble lifting them when changing the water.