It depends on the use.

Rechargeables, especially high-quality rechargeables, are great in devices that you're maintaining regularly. The device may have some parasitic drain, and all batteries have a self-discharge rate. So I use rechargeables in places it makes sense for me and my patterns of use.

Primaries make more sense for long-term storage, as they can have a very low self-discharge rate, especially lithium primaries.

NiCds suck. NiMHs (especially Eneloops) can be very good, as can LIon batteries like 18650s.