fwiw scout pits aren't exactly leave no trace - if you're running a class, I hope you're digging on your own property? And replacing your divots?

Digging a pit is also a high exertion exercise, not conducive to most survival situations. As you say, they may be okay if you're hiding from hostiles or don't have other options to get out of wind or weather, but where exactly in your perimeter will you find hostiles or a lack of above ground options that necessitate digging a pit?

In the PNW I wouldn't trust a scout pit to remain dry - and creepy crawlies might invade, which would bug me out within a night or two. Closest I have come is digging snow out of a tree well and topping that with a tent rainfly - safe, dry, out of the wind and reasonably warm with the temperature below freezing. And it burned the poor Scouts who were digging snow caves all afternoon when I moved over 20 yards and dug out my tree well shelter in about a half an hour.