No sock ever made would last forever with my feet. I've got very long big toes and worse yet the left big toe is 2 sizes larger than the right one. So I am constantly poking holes in my socks right where Mr. Big is.
If I had a penchant for darning - I could lessen my spending on replacements just by repairing these holes. But for the best bang for the money, I buy my wool socks at Costco and since I wear wool socks 99% of the time, it is just easier for me to replace the holey socks with new ones.

Edit: just watched the video. I didn't realize this was from Canadian Prepper (he lives about 3 hrs from me in Martensville, SK). So these socks should be available in my area. I still don't think these would last any longer than Costco wool but if there is a lifetime warranty, I could run this company out of business exchanging them every couple of months!